Skip to content

feat: add fallback version support for share filtering #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ScriptedAlchemy
Copy link
Member

Summary

  • Add fallbackVersion field to include/exclude filters in ConsumeSharedPlugin and ProvideSharedPlugin
  • Implement fallback version checking logic that activates when primary version detection fails
  • Add comprehensive unit and integration tests for fallback version functionality

Changes

  • Updated JSON schemas to include fallbackVersion field in include/exclude options
  • Added fallbackVersion logic to ConsumeSharedPlugin.ts and ProvideSharedPlugin.ts
  • Created unit tests covering various fallback version scenarios
  • Added integration test with mock node_modules structure
  • Updated PR plan to clarify share-filter as the base branch for all PRs

Test plan

  • Unit tests pass for fallback version functionality
  • Integration tests verify webpack builds correctly with fallback version config
  • Schema regeneration completes successfully
  • Manual testing with real module federation setup

🤖 Generated with Claude Code

Copy link

changeset-bot bot commented Jul 15, 2025

⚠️ No Changeset found

Latest commit: 696aae5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy force-pushed the pr6-fallback-version-support branch 5 times, most recently from 98e517b to 3757776 Compare July 15, 2025 04:43
@ScriptedAlchemy ScriptedAlchemy force-pushed the pr5-request-pattern-filtering branch from c9d0145 to 76e707f Compare July 21, 2025 22:09
@ScriptedAlchemy ScriptedAlchemy force-pushed the pr6-fallback-version-support branch from c7d9cce to 696aae5 Compare July 22, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant