Skip to content

Conversation

@ryok90
Copy link
Contributor

@ryok90 ryok90 commented Oct 20, 2025

Description

Fix Metro E2E test failures in CI by adding build step for Metro packages and fixing package name mismatch.

Android Error: ERR_MODULE_NOT_FOUND - Missing dist/ folder in @module-federation/metro-plugin-rnef
iOS Error: rnef.config not found - Path mismatch between package name and directory

Changes:

  • Added build step to android-e2e and ios-e2e actions to build Metro packages before running tests
  • Renamed package from example-host to metro-example-host to match directory structure
  • Updated workflow matrix to use metro-example-host
  • Removed unnecessary build-metro dependency from e2e-metro job

Related Issue

Fixes failing CI:

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

⚠️ No Changeset found

Latest commit: 51491fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryok90
Copy link
Contributor Author

ryok90 commented Oct 20, 2025

@2heal1 heey can you check this?
seems like the workflow was not working before.
it's pointing towards your branch
#4141

edit: still not working, putting it in draft

@ryok90 ryok90 marked this pull request as draft October 20, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant