Compatibility with MODX 3 #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibochkarev
reviewed
Dec 7, 2021
There was a problem hiding this comment.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/core/src/Revolution/Transport/modPackageBuilder.php : 147) Создан новый пакет с подписью: pdotools-3.0.0-beta
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/core/src/Revolution/Transport/modPackageBuilder.php : 186) Зарегистрировано пространство имён пакета: pdotools
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/core/src/Revolution/Transport/modPackageBuilder.php : 204) Пространство имён «pdotools» упаковано в пакет.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 50) Created Transport Package and Namespace.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 77) Packaged in 10 snippets.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 98) Packaged in 1 plugins.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 139) Packaged in 8 System Settings.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 158) Packaged in 1 Plugins events.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 172) Added package attributes and setup options.
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 175) Packing up transport package zip...
[2021-12-07 03:59:22] (INFO @ /Users/bochkarev/Desktop/modx-3.0.0-beta2/pdoTools/_build/build.transport.php : 227)
Execution time: 0.1831 sПосле установки создается пакет в core/packages/pdotools-3.0.0-beta.transport.zip
Но пакет не устанавливается
- Переходим в Менеджер пакетов - Искать пакеты локально
- Видим в списке пакет для установки
- Нажимаем установить
Админка падает
Уточнение не был запущен composer install
|
Для тестирования: gh repo clone modx-pro/pdoTools
cd pdoTools
gh pr checkout https://github.com/modx-pro/pdoTools/pull/319
cd core/components/pdotools
composer installДалее заходим в менеджер пакетов, поиск пакетов локально, устанавливаем pdotools-3.0.0-beta.transport.zip - собранный пакет |
|
pdotools-3.0.0-beta.transport.zip |
|
Синтаксис FastField ( |
ilyautkin
approved these changes
Dec 7, 2021
Несколько улучшений по коду рефакторинга
Add MODX as dev-dependency for local development
prepateTVs = 1 and processTVs = 1 stopped working in v.3.0.0-Beta as the equality check changed to identity check. But all values arriving from usual snippet calls and property sets arrive as string instead of number, making the "=== 1" check always fail, except maybe if calling the snippets by using the MODX runSnippet API.
Fix prepareTVs and processTVs = 1 not working
[3.0.0-beta] fatal error in connector.php
Fix makeUrl method properties
Замена имени класса на FQN.
[С некоторых пор](ab4934d#diff-df1b56538c6abe3aefac65ce5f4a027cc988cb15e21882bb272cdcb06281c2f5R142) `pdoPage` вызывает все сниппеты в `element` некэшируемыми, принудительно подставляя восклицательный знак перед именем. Это ломает работу файловых сниппетов: ``` {'!pdoPage' | snippet : [ 'element' => '@file elements/snippets/overview.snippet.php', 'tplPage' => '@file elements/chunks/pagination/page.tpl', 'tplPageWrapper' => '@file elements/chunks/pagination/page-wrapper.tpl' ]} ``` Имя получается `!@file elements...`, собачка на 1й позиции считается за Property Set и сниппет не может быть загружен. Данное изменение это исправляет, позволяя указывать восклицательный знак и для элементов c биндингами.
Поддержка файловых сниппетов в pdoPage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что оно делает?
Реализует совместимость pdoTools с MODX 3.0.
Зачем это нужно?
Сделать возможным использование самой популярной библиотеки с новой версией MODX.
Связанные проблема(ы)/PR(ы)
Нет