Fix separator for menu item without children

[theboxer]

What does it do?

Adds separator for menu items without children

Why is it needed?

Missing separator

How to test

Create menu entry without children

Related issue(s)/PR(s)

Resolves #16645

[smg6511]

So, this definitely corrects the issue as-is. Thus I went ahead and approved.

I made some suggestions, nonetheless, because I noticed that having the $top var serves no purpose so you might as well simply add the top class to the <li> directly (and, the top-link css class is not used in 3.x). Plus, really we want to select all top-level nav <li>s to apply the top border, so the selector in the scss file can be simplified (as noted in the second comment).

Anyway, up to you if you want to incorporate these changes. If you think it's too nit-picky, no problem ;-)

[theboxer]

@smg6511 thx for the suggestions, added them all

[opengeek]

This PR includes the compiled assets. Can you remove those @theboxer?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.60%. Comparing base (9a3f82c) to head (662c141).
Report is 24 commits behind head on 3.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                3.x   #16647      +/-   ##
============================================
+ Coverage     21.47%   21.60%   +0.13%     
- Complexity    10652    10713      +61     
============================================
  Files           561      564       +3     
  Lines         32268    32373     +105     
============================================
+ Hits           6929     6995      +66     
- Misses        25339    25378      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.