[3.1] A11y/ManagerMenu: hotfix for links not clickable 3th level #16671
Conversation
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/extjs-problems-on-newly-installed-site/8247/2 |
There was a problem hiding this comment.
This does appear to fix the issue at hand ;-)
However, and I'll post an issue on this, there is a usability issue that this causes (the original a11y addition, not this PR specifically): It removes focus from the modals and overlay windows that may appear as a result of clicking a menu item. Clear Cache is a primary example. You cannot press return/enter to submit the window's form; you must click on it.
Also - I don't know if this poses a merging challenge, but I noticed this PR is applied on the current -pl rather than the 3.1.1-dev branch. Check with Jason (@opengeek) on that...
@smg6511 thank you for reviewing it!
I can confirm that this is a recent bug. When you click "Clear Cache", the focus leaves the navigation. The modal gets the focus, but then the eventlistener from the navigation sets the focus back to the subnav opener button. I'll look into this.
This is my fault. Is it possible for @opengeek to change this on your site, or should I open a new PR in the 3.1.1-dev branch? |
I don't see any issue with this PR? There is no separate branch for 3.1.1-dev; it's all just 3.x. @smg6511 — are you just referring to it being applied before I bumped the version in the 3.x branch? That will not be an issue. 😉 |
|
@opengeek - Just wanted to point it out since usually when pulling down something to test from the 3.x branch, the UI will show the current dev # (expecting 3.1.1-dev); but when I was testing, it showed up as 3.1.0-pl. Sounds like it's just a timing thing. |
Yep, understood. It's only an issue if the commits touch the same lines in the same files. |
|
…#16667 - remove variables subNavOpen and _this - set focusRestoreEls from array to focusRestoreEl as object - remove the class from the submenu instead of using hide() - refactor to use requestAnimationFrame() instead of setTimeout()
opengeek
force-pushed
the
a11y_managermenu_hotfix_links_not_clickable_3th_level
branch
from
68f1314 to
236f484
Compare
What does it do?
Hopefully it fixes #16667.
How to test
Related issue(s)/PR(s)
#16530
#16667