Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non-functioning Remember Me login feature #16685

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Jan 22, 2025

What does it do?

Casts rememberme property to boolean to ensure proper functionality.

Why is it needed?

User sessions are not persisted even when use checks Remember Me during login.

How to test

  1. Set your session_cookie_lifetime system setting to a short time (I set it to 180 [3 minutes]).
  2. Login without checking Remember Me and verify that, when quitting the browser (while still logged in), you are NOT automatically logged in when re-opening the browser and revisiting the manager
  3. Login with Remember Me checked and, within the 3 minutes (or whatever lifetime you set), quit and re-open the browser to verify automatic login is functioning.
  4. Again, before your 3 minute session lifetime has expired, quit the browser (while still logged in).
  5. After the 3 minutes has elapsed, open your browser again to verify you are NOT automatically logged in.

Related issue(s)/PR(s)

Resolves #16518

Formatting, code quality changes only
Fix eval of rememberme prop
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Jan 22, 2025
@smg6511 smg6511 changed the title 3.x issue 16518 Fix for non-functioning Remember Me login feature Jan 22, 2025
@opengeek opengeek merged commit 423b9d8 into modxcms:3.x Jan 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Remember me" is not setting an expiration date and time for session cookies in MODX 3.0
3 participants