Fix for MODX updates widget #16694
Merged
Fix for MODX updates widget #16694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix updates display when only a single modx update is available
opengeek
approved these changes
Jan 24, 2025
opengeek
pushed a commit
that referenced
this pull request
Jan 24, 2025
### What does it do? Fixes error in array selection when only one update is available. ### Why is it needed? MODX update status is not showing properly (both when there is an update and when MODX _is_ up to date) when the software update API only returns one option. ### How to test 1. Verify software status displays "Up to Date" on this dev branch 2. Manually apply this change on the 3.0.x branch to verify the 3.1.0 update shows and is downloadable via the widget ### Related issue(s)/PR(s) None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes error in array selection when only one update is available.
Why is it needed?
MODX update status is not showing properly (both when there is an update and when MODX is up to date) when the software update API only returns one option.
How to test
Related issue(s)/PR(s)
None