Skip to content

Fix fatal error in trim output filter #16757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 3.x
Choose a base branch
from
Open

Fix fatal error in trim output filter #16757

wants to merge 4 commits into from

Conversation

jenswittmann
Copy link
Contributor

This solves a PHP fatal error that occurs when using something like this:

[[!#SESSION.user.password:trim]]

PHP Error

Fatal error: Uncaught TypeError: trim(): Argument #1 ($string) must be of type string, array given in core/src/Revolution/Filters/modOutputFilter.php:66 Stack trace: #0 core/src/Revolution/Filters/modOutputFilter.php(66): trim(Array) #1 core/src/Revolution/modTag.php(354): MODX\Revolution\Filters\modOutputFilter->filter(Object(ModxPro\PdoTools\Parsing\Tag)) #2 core/components/pdotools/src/Parsing/Tag.php(32): MODX\Revolution\modTag->filterOutput() #3 core/components/pdotools/src/Parsing/Parser.php(264): ModxPro\PdoTools\Parsing\Tag->process() #4 core/src/Revolution/modParser.php(221): ModxPro\PdoTools\Parsing\Parser->processTag(Array, true) #5 core/components/pdotools/src/Parsing/Parser.php(73): MODX\Revolution\modParser->processElementTags('', '<!DOCTYPE html>...', true, false, '[[', ']]', Array, 9) #6 core/src/Revolution/modResource.php(520): ModxPro\PdoTools\Parsing\Parser->processElementTags('', '<!DOCTYPE html>...', true, false, '[[', ']]', Array, 10) #7 core/src/Revolution/modResource.php(468): MODX\Revolution\modResource->parseContent() #8 core/src/Revolution/modResponse.php(72): MODX\Revolution\modResource->prepare() #9 core/src/Revolution/modRequest.php(154): MODX\Revolution\modResponse->outputContent(Array) #10 core/src/Revolution/modRequest.php(138): MODX\Revolution\modRequest->prepareResponse() #11 core/src/Revolution/modX.php(1509): MODX\Revolution\modRequest->handleRequest() #12 index.php(63): MODX\Revolution\modX->handleRequest() #13 {main} thrown in core/src/Revolution/Filters/modOutputFilter.php on line 66

System

  • MODX 3.1.2
  • PHP Version 8.3.21
  • Extras: pdoTools 3.0.2-pl

@rthrash
Copy link
Member

rthrash commented Jul 11, 2025

@jenswittmann does that happen outside of pdotools?

@opengeek opengeek changed the title [3.1.2] bugfix trim() fatale error in modOutputFilter.php Fix fatal error in trim output filter Jul 11, 2025
@jenswittmann
Copy link
Contributor Author

@jenswittmann does that happen outside of pdotools?

Yes, you can try this with a Snippet that return an Array:

<?php

return [
    'demo' => 'test'
];

When you use [[demo:trim]] the error occurs.

smg6511
smg6511 suggested changes Jul 14, 2025
View reviewed changes
@jenswittmann
Copy link
Contributor Author

@smg6511 here's a real-world example that might not work with the discussed fix maybe 🤔

Check if the user has a name in a custom session variable and output a link based on it:

[[!#SESSION.user.password:is=``:then=`<a href="/login">Login</a>`:else=`<a href="/login?logout=true">Logout</a>`]]

Every output modifier gets trimmed in line 66. So, with return, you always get the else value, right?

@smg6511
Copy link
Collaborator

smg6511 commented Jul 15, 2025 •
edited
Loading

@jenswittmann - No, I did some tests with [[#!GET.somekey:trim:is=...]] in various ways and it works like you want it to with the early return. The benefit of the early return is that if you happen to unintentionally apply filters on an array, using [[#GET:trim:is=...]] for example, you'll just get back a string representation of the array (or just "Array"). Otherwise you would get the else value.

@smg6511
Copy link
Collaborator

smg6511 commented Sep 19, 2025

@jenswittmann Hi again, Jens. SInce you were active earlier today (on the file browser update I did), I thought I'd see if you wanted to take a second look and consider implementing the changes I'd suggested for your PR here. Then I can re-review and maybe we can get this one merged in soon as well ;-)

@jenswittmann
Copy link
Contributor Author

@smg6511 can confirm that both suggestion fixed it!

smg6511
smg6511 approved these changes Sep 21, 2025
View reviewed changes
Copy link
Collaborator

@smg6511 smg6511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

1 more reviewer

@smg6511 smg6511 smg6511 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenswittmann @rthrash @smg6511 @opengeek