File resolve options #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let user set cacheManager copy options, such as 'copy_exclude_patterns'
Let user set cacheManager copy options, such as 'copy_exclude_patterns'
Let user set cacheManager copy options, such as 'copy_exclude_patterns'
|
Usage: add xPDOTransport::FILE_RESOLVE_OPTIONS => array() to the $builder->createVehicle (vehicle global) or $vehicle->resolve (single object) attributes |
|
Other than some formatting issues, this is a great PR, but could you reapply these changes and submit it to the 2.x branch of the main xpdo repository @ https://github.com/modxcms/xpdo/tree/2.x instead of this one? This is just a subtree merge of the xpdo/ directory of xPDO 2.x branch and this repository will be closed down once 2.x development is closed in the not too distant future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let user set cacheManager copy options, e.g. 'copy_exclude_patterns' to exclude specific subdirectories from the transport package