423 max abstract #478
Merged
423 max abstract #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadronCollider
requested changes
Nov 27, 2023
|
|
||
| def late_init(self): | ||
| self.headers = self.file.make_headers(self.file_type['report_type']) | ||
| self.max_size = 1 |
There was a problem hiding this comment.
Размер стоит вынести в аргументы конструктора (= критерия)
Comment on lines
29
to
30
| referat_size = abstract_page - referat_page | ||
| abstract_size = main_page - abstract_page |
There was a problem hiding this comment.
напомните, что хранится по ключу в self.headers - просто страницы?
There was a problem hiding this comment.
Да, номера страниц, с которых начинается раздел
Comment on lines
31
to
34
| if referat_size > self.max_size: | ||
| return answer(False, | ||
| f"<br><br>Размер раздела \"Реферат\" равен {referat_size} страницы, должен быть {self.max_size}") | ||
| if abstract_size > self.max_size: |
There was a problem hiding this comment.
Возможно стоит проверять их в один момент (в плане фидбека, чтобы не было "получил уведомление о реферате -> исправил реферат -> только потом узнал, что ещё и Abstract неверное")
HadronCollider
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.