Remove dependency

mohsaka · Dec 9, 2024 · 2f2b418 · 2f2b418
1 parent 2ec9cc0
commit 2f2b418
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/velox/expression/FunctionSignature.cpp b/velox/expression/FunctionSignature.cpp
@@ -18,9 +18,10 @@
 
 #include "velox/common/base/Exceptions.h"
 #include "velox/expression/FunctionSignature.h"
-#include "velox/functions/prestosql/types/IPPrefixType.h"
 #include "velox/type/Type.h"
 
+constexpr folly::StringPiece ipPrefixTypeName{"IPPREFIX"};
+
 namespace facebook::velox::exec {
 
 std::string sanitizeName(const std::string& name) {
@@ -122,7 +123,7 @@ void validateBaseTypeAndCollectTypeParams(
     if (!isPositiveInteger(typeName) &&
         !tryMapNameToTypeKind(typeName).has_value() &&
         !isDecimalName(typeName) && !isDateName(typeName) &&
-        !isIPPrefixName(typeName)) {
+        !(typeName == ipPrefixTypeName)) {
       VELOX_USER_CHECK(hasType(typeName), "Type doesn't exist: '{}'", typeName);
     }
 

diff --git a/velox/functions/prestosql/types/IPPrefixType.h b/velox/functions/prestosql/types/IPPrefixType.h
@@ -139,10 +139,6 @@ FOLLY_ALWAYS_INLINE bool isIPPrefixType(const TypePtr& type) {
   return IPPrefixType::get() == type;
 }
 
-FOLLY_ALWAYS_INLINE bool isIPPrefixName(const std::string& name) {
-  return (name == IPPrefixType::get()->name());
-}
-
 FOLLY_ALWAYS_INLINE std::shared_ptr<const IPPrefixType> IPPREFIX() {
   return IPPrefixType::get();
 }