Add IPPREFIX for fuzzer

mohsaka · Oct 9, 2024 · 53f3261 · 53f3261
1 parent 303162e
commit 53f3261
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/velox/expression/FunctionSignature.cpp b/velox/expression/FunctionSignature.cpp
@@ -18,6 +18,7 @@
 
 #include "velox/common/base/Exceptions.h"
 #include "velox/expression/FunctionSignature.h"
+#include "velox/functions/prestosql/types/IPPrefixType.h"
 #include "velox/type/Type.h"
 
 namespace facebook::velox::exec {
@@ -120,7 +121,8 @@ void validateBaseTypeAndCollectTypeParams(
 
     if (!isPositiveInteger(typeName) &&
         !tryMapNameToTypeKind(typeName).has_value() &&
-        !isDecimalName(typeName) && !isDateName(typeName)) {
+        !isDecimalName(typeName) && !isDateName(typeName) && 
+        !isIPPrefixName(typeName)) {
       VELOX_USER_CHECK(hasType(typeName), "Type doesn't exist: '{}'", typeName);
     }
 

diff --git a/velox/expression/fuzzer/ExpressionFuzzer.cpp b/velox/expression/fuzzer/ExpressionFuzzer.cpp
@@ -122,6 +122,12 @@ void addCastFromDateSignature(
   signatures.push_back(makeCastSignature("date", toType));
 }
 
+void addCastFromIPPrefixSignature(
+    const std::string& toType,
+    std::vector<facebook::velox::exec::FunctionSignaturePtr>& signatures) {
+  signatures.push_back(makeCastSignature("ipprefix", toType));
+}
+
 std::vector<facebook::velox::exec::FunctionSignaturePtr>
 getSignaturesForCast() {
   std::vector<facebook::velox::exec::FunctionSignaturePtr> signatures;
@@ -146,6 +152,7 @@ getSignaturesForCast() {
   addCastFromVarcharSignature("varchar", signatures);
   addCastFromDateSignature("varchar", signatures);
   addCastFromTimestampSignature("varchar", signatures);
+  addCastFromIPPrefixSignature("varchar", signatures);
 
   // To timestamp type.
   addCastFromVarcharSignature("timestamp", signatures);
@@ -155,6 +162,9 @@ getSignaturesForCast() {
   addCastFromVarcharSignature("date", signatures);
   addCastFromTimestampSignature("date", signatures);
 
+  // To ipprefix type.
+  addCastFromVarcharSignature("ipprefix", signatures);
+
   // For each supported translation pair T --> U, add signatures of array(T) -->
   // array(U), map(varchar, T) --> map(varchar, U), row(T) --> row(U).
   auto size = signatures.size();

diff --git a/velox/functions/prestosql/types/IPPrefixType.h b/velox/functions/prestosql/types/IPPrefixType.h
@@ -57,6 +57,10 @@ class IPPrefixType : public RowType {
   }
 };
 
+FOLLY_ALWAYS_INLINE bool isIPPrefixName(const std::string& name) {
+  return (name == IPPrefixType::get()->name());
+}
+
 FOLLY_ALWAYS_INLINE bool isIPPrefixType(const TypePtr& type) {
   // Pointer comparison works since this type is a singleton.
   return IPPrefixType::get() == type;