-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #4
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 94.83% 97.35% +2.52%
==========================================
Files 17 16 -1
Lines 949 1438 +489
==========================================
+ Hits 900 1400 +500
+ Misses 49 38 -11 ☔ View full report in Codecov by Sentry. |
Actually, I just realised that since |
MKVToolNix cannot provide the PTS (Presentation Time Stamp) of a frame directly. Instead, it only offers timestamps in milliseconds, which lack the precision needed for certain tasks.
1. Rename ms to number 2. Correct the round_method so it round correctly for negative number.
Now, we only support ffprobe has a video "parser", so we don't need a abstract class anymore
Don't round the timestamps. The decision or rounding will be taken from ABCTimestamps.
Now, we have FPSTimestamps, VideoTimestamps and TextFileTimestamps. They now support different unit of time (milliseconds, nanoseconds, etc)
We don't need mkvtoolnix anymore
There isn't any reason to not use ubuntu-latest
A big refactor is needed to close #2 and #3.
For the moment, I only edited the
Algorithm conversion explanation.md
doc.