Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom impl Debug for Duration #52

Merged
merged 1 commit into from
Dec 14, 2023
Merged

custom impl Debug for Duration #52

merged 1 commit into from
Dec 14, 2023

Conversation

jankeu
Copy link
Contributor

@jankeu jankeu commented Dec 14, 2023 •
edited
Loading

reuses Durations Display implementation for Debug output

@jankeu jankeu changed the title custom Debug for Duration custom impl Debug for Duration Dec 14, 2023
@jankeu jankeu marked this pull request as ready for review December 14, 2023 10:43
fabian-braun
fabian-braun approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@fabian-braun fabian-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe adding a comment to the Display impl that it is reused would be warranted?

@jankeu jankeu merged commit b1840b7 into main Dec 14, 2023
3 checks passed
@jankeu jankeu deleted the hack/add-duration-debug branch December 14, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabian-braun fabian-braun fabian-braun approved these changes

@rinde rinde rinde approved these changes

@jan-xyz jan-xyz Awaiting requested review from jan-xyz

@lxwbr lxwbr Awaiting requested review from lxwbr lxwbr is a code owner

@urmaul urmaul Awaiting requested review from urmaul urmaul is a code owner

@Felerius Felerius Awaiting requested review from Felerius Felerius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankeu @rinde @fabian-braun