Skip to content

Commit

Permalink
Merge pull request #1713 from moj-analytical-services/make_sqlglot_na…
Browse files Browse the repository at this point in the history
…me_a_property

add `@property` decorator to `sqlglot_name` method
  • Loading branch information
ThomasHepworth authored Nov 8, 2023
2 parents c6e340e + f5d38bf commit 0754c8f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion splink/comparison_level_creator.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def create_level_dict(self, sql_dialect_str: str) -> dict:

@final
def input_column(self, sql_dialect: SplinkDialect) -> InputColumn:
return InputColumn(self.col_name, sql_dialect=sql_dialect.name)
return InputColumn(self.col_name, sql_dialect=sql_dialect.sqlglot_name)

@final
def configure(
Expand Down
1 change: 1 addition & 0 deletions splink/dialects.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class SplinkDialect(ABC):
def name(self):
pass

@property
def sqlglot_name(self):
return self.name

Expand Down

0 comments on commit 0754c8f

Please sign in to comment.