Skip to content

Commit

Permalink
don't select columns we don't need
Browse files Browse the repository at this point in the history
this double-selection (of count_l, count_r - once each in * and once each explicitly) can cause errors in some dialects, in some execution modes
  • Loading branch information
ADBond committed Oct 23, 2024
1 parent e533699 commit 7ce6f0a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion splink/internals/blocking_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def _count_comparisons_from_blocking_rule_pre_filter_conditions_sqls(
)

sql = f"""
select *, count_l, count_r, count_l * count_r as block_count
select count_l, count_r, count_l * count_r as block_count
from __splink__count_comparisons_from_blocking_l
inner join __splink__count_comparisons_from_blocking_r
using ({using_str})
Expand Down

0 comments on commit 7ce6f0a

Please sign in to comment.