-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check input frames have same columns - missingness #1611
Conversation
@@ -249,18 +249,38 @@ def __init__( | |||
self.debug_mode = False | |||
|
|||
@property | |||
def _get_input_columns( | |||
def _input_columns( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't see Sam's PR from last month, but it duplicates some of the functionality within the settings validation class.
I think the linker object is a better place to house this code, but can we consolidate the two?
All I need on my end is the column_names_by_input_df
variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to trim remove the quotes from our column names, there's some code in the settings validator to do this too. Though, I don't think this is a necessity.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Closes #808.
Give a brief description for the solution you have provided
The main thing here is that the property
linker._input_columns
now checks columns for all input dataframes, and gives a clear error message if they are not identical sets, outputting columns that are not common to all frames.Other changes:
linker._get_input_columns
->linker._input_columns
(clearer name for property vs method)linker._input_columns
returns a list ofInputColumn
s rather than just theirname
s, for flexibilityprofile_data
accordinglylinker._input_columns
for missingness chart so we get the check for freemissingness_chart
docstringPR Checklist