Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected docstring to match connected components algorithm #1702

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Corrected docstring to match connected components algorithm #1702

merged 2 commits into from
Nov 6, 2023

Conversation

zslade
Copy link
Contributor

@zslade zslade commented Nov 6, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Following on from this Slack post: https://asdslack.slack.com/archives/C02TCQLLJAX/p1698392446717119

Give a brief description for the solution you have provided

Correcting docstring to "at or above this threshold" so that it matches the connected components algorithm implementation

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

RossKen
RossKen approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot - thanks! 🥳

@zslade zslade merged commit eb697e5 into master Nov 6, 2023
8 checks passed
@zslade zslade deleted the correct_doctsring branch November 6, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossKen RossKen RossKen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zslade @RossKen