Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @property decorator to sqlglot_name method #1713

Merged
merged 2 commits into from
Nov 8, 2023
Merged

add @property decorator to sqlglot_name method #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a3394e
add `@property` decorator to `sqlglot_name` method
ThomasHepworth Nov 8, 2023
f5d38bf
use `sqlglot_name` in sqlglot calls
ThomasHepworth Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion splink/comparison_level_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def create_level_dict(self, sql_dialect_str: str) -> dict:

@final
def input_column(self, sql_dialect: SplinkDialect) -> InputColumn:
return InputColumn(self.col_name, sql_dialect=sql_dialect.name)
return InputColumn(self.col_name, sql_dialect=sql_dialect.sqlglot_name)

@final
def configure(
Expand Down
1 change: 1 addition & 0 deletions splink/dialects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class SplinkDialect(ABC):
def name(self):
pass

@property
def sqlglot_name(self):
return self.name

Expand Down