Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InputColumn quoting for spark and improve code quality #1719

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix InputColumn quoting for spark and improve code quality #1719

merged 1 commit into from
Nov 13, 2023

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Nov 9, 2023

See #1712

@RobinL RobinL linked an issue Nov 9, 2023 that may be closed by this pull request
[BUG] InputColumn does not work properly with Spark columns that need escaping #1712
Closed
ADBond
ADBond approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@RobinL RobinL merged commit 9ae3014 into master Nov 13, 2023
8 checks passed
@RobinL RobinL deleted the 1712-bug-inputcolumn-does-not-work-properly-with-spark-columns-that-need-escaping branch November 13, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADBond ADBond ADBond approved these changes

@ThomasHepworth ThomasHepworth Awaiting requested review from ThomasHepworth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] InputColumn does not work properly with Spark columns that need escaping
2 participants
@RobinL @ADBond