Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.9.9 #1735

Merged
merged 4 commits into from
Nov 14, 2023
Merged

3.9.9 #1735

merged 4 commits into from
Nov 14, 2023

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Nov 14, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there might be some more recent changes that haven't made it into the changelog (whilst we are adopting it - some of the branches were pre-changelog) - would be good to add these (by cross-referencing the github release notes), but that can also be done as a separate PR (and I am happy to do that if so)

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@RossKen
Copy link
Contributor Author

RossKen commented Nov 14, 2023

i think there might be some more recent changes that haven't made it into the changelog (whilst we are adopting it - some of the branches were pre-changelog) - would be good to add these (by cross-referencing the github release notes), but that can also be done as a separate PR (and I am happy to do that if so)

Cool, thanks for the comments - I will look out what I can to add to the changelog

@RossKen
Copy link
Contributor Author

RossKen commented Nov 14, 2023

@ADBond I wasn't too sure what exactly is of interest in the changelog (user-facing vs internal changes etc) so I have added what I think may be useful for people. Going to merge this now to get the release out, but feel free to add anything else to the changelog in a separate PR if you think they is important.

@RossKen RossKen merged commit c273a41 into master Nov 14, 2023
@RossKen RossKen deleted the 3.9.9 branch November 14, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants