Make spellcheck work cross-platform #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zslade are you happy for us to go ahead and merge this? Looks ok to me... |
I was waiting for @ThomasHepworth to return from leave to discuss but happy to review sooner if you want to reduce the PR backlog |
|
No rush on this from my end, I can just direct Jonathan to these docs in PR form (since he is planning to contribute to the documentation and is not on a Mac). |
ThomasHepworth
requested changes
Apr 8, 2024
zslade
reviewed
Apr 9, 2024
|
For reference, have addressed the LibreOffice query here: #2101 (comment) |
Co-authored-by: Tom Hepworth <[email protected]>
Co-authored-by: Zoe Slade <[email protected]>
zslade
reviewed
Apr 25, 2024
|
@zmbc, are you happy to make the last couple of small suggested changes to this and update the branch? Then we can get this merged into master :) |
zslade
approved these changes
May 10, 2024
ThomasHepworth
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
#2101
Give a brief description for the solution you have provided
Adds cross-platform support to the spell-checker script. Simplifies passing of directory to spellcheck. Removes LibreOffice dictionary step which does not seem to be needed?
PR Checklist