Handle threshold_match_probablity 0 in predict() #2420 #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Updated function to handle threshold_match_probability 0 as None. Modified the logic in lines 100-117, this is to prevent maths errors when doing log2.
RobinL
reviewed
Sep 27, 2024
| @@ -97,7 +97,9 @@ def predict_from_comparison_vectors_sqls( | |||
| bf_terms, | |||
| sql_infinity_expression, | |||
| ) | |||
|
|
|||
| # Add condition to treat case of 0 as None | |||
| if threshold_match_probability == 0: | |||
There was a problem hiding this comment.
There's whitespace at the end of these lines at the moment hence ruff is failing.
Really the best solution is to process using ruff, but removing the whitespace manually should do it
There was a problem hiding this comment.
Hey, yeah sorry i thought I'd fixed that let me have another look
There was a problem hiding this comment.
That should have done it now, it was on line 102, sorry im very new to this stuff.
|
Thanks. Closes #2420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated predict_from_comparison_vectors_sqls_using_settings function to handle threshold_match_probability 0 as None. Modified the logic in lines 100-117, this is to prevent maths errors when doing log2.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Existing Issue #2420
Give a brief description for the solution you have provided
Whenever this predict function is called it will first check for 0 and assign threshold_match_probability to None.
Then when it is later passed into log2 it won't return a math error.
As its a minor change I haven't changed documentation or changelog.
PR Checklist