Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of second __splink__cluster_count_row_numbered query, prevent table name conflict #2447

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

browo097302
Copy link
Contributor

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

#1823

Give a brief description for the solution you have provided

The second query that goes to enqueue __splink__cluster_count_row_numbered has the same name as a query already executed in lines 226 and 232. This leads to a "table already exists" error, so I have simply renamed the last query to __splink__cluster_count_row_numbered_2 as just changing the name was advised in the issue description.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter
  • Run the spellchecker (if appropriate)

@ADBond
Copy link
Contributor

ADBond commented Oct 14, 2024

Great, thanks!

@ADBond ADBond merged commit 96e6602 into moj-analytical-services:master Oct 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants