Test and fix debug mode #2481
Merged
Test and fix debug mode #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really it's slightly odd that the postgres tests fail - but looks like that is a separate issue. |
this double-selection (of count_l, count_r - once each in * and once each explicitly) can cause errors in some dialects, in some execution modes
…s-select Explicit selection
this prevents looking up the wrong table when using debug mode
…broken-clustering Fix clustering in debug mode
This reverts commit 0442718.
…debug-mode Less caching in debug mode
without this, tests become coupled - specifically failures in `tests/test_debug_mode.py::test_debug_mode_clustering` and `tests/test_debug_mode.py::test_debug_mode_cluster_studio` cause failures in `tests/test_u_train.py::test_u_train_link_only` if run beforehand in the same test session
circumvents an issue with parquet method, where empty tables may be cleaned up before they are queried, particularly problematic in debug mode
…session-handling Spark test session handling
|
@RobinL - there's nothing particularly major here, but might be worth a glance over. All of the 'real' changes are in separate PRs with some explanation should you feel the need. Beyond that it might also be useful to look at the test decorator for checking issues with functionality in debug mode, to see if you think that seems a sensible way to go about it. |
RobinL
approved these changes
Nov 12, 2024
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests of various bits of functionality with
debug_modeswitched on. Tests are structured so that we can check that issues specifically arise only whendebug_modeis on - if the test fails when it is off, a different error will be flagged, to help isolate things. These can be expanded to help diagnose issues, but just as an initial starting point.This will also include fixes for the failing tests, which will be opened as separate PRs into this branch:
Partial work towards #2429. This tackles 'does stuff work when
debug_modeis switched on, but doesn't address 'isdebug_modedoing what we think it is'.