Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArrayIntersect default #2587

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add ArrayIntersect default #2587

merged 1 commit into from
Jan 22, 2025

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Jan 16, 2025

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

NA

Give a brief description for the solution you have provided

ArrayIntersect docs say that min intersect is 1 by default, but this isn't in the code. Adding default of one to match the docstring.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter
  • Run the spellchecker (if appropriate)

@RossKen RossKen requested review from ADBond and RobinL January 16, 2025 13:14
@RossKen RossKen changed the title Update comparison_level_library.py Add ArrayIntersect default Jan 16, 2025
Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RobinL RobinL merged commit d0a5d17 into master Jan 22, 2025
26 of 28 checks passed
@RobinL RobinL deleted the array-intersect-default branch January 22, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants