Create style_guide #429
Merged
Create style_guide #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Waterfield <[email protected]>
ian-rickard
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Hi, first of all, I am very sorry for leaving this review til so late. Second, I think this is great and will be super useful at helping promote consistency and readability and ultimately making everyone's lives easier. Third, I did have some recommendations and I'm happy to also convert any that are agreed with into substantive edits if that's useful
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
source/documentation/tools/create-a-derived-table/style-guide.md
Outdated
Show resolved
Hide resolved
SoumayaMauthoorMOJ
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
@hollyfurniss-moj sorry to be a pain but can you add a brief explanation about what you mean by data modelling because I'm not sure this is a term understood by analyst and it has multiple meanings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.