Webapps refactor #431
Open
Webapps refactor #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app section on the user guidance needed a good overhaul / refactor. Lots of the information under the RShiny app page was also relevant to other webapps, so I decided to add it to its own pages and reference from the RShiny / webapp page itself. This will make it a bit clearer for the reader I believe.
I have also added in some needed guidance on data access for apps as it is dependent on whether the user has setup a webapp data source or is trying to use a pre-existing warehouse data source bucket. Also there is an additional step if the app needs to execute Athena queries. These can be found in a new page called 'managing-app-data-access'.
Lastly, a small change and update to the amazon-s3 page in /data was required for consistency. It seemed sensible to include it here than a separate PR (@SoumayaMauthoorMOJ to review this page only)
Michael