feat: add merchant registry helm charts #598
Conversation
tw-sithumyo
requested review from
mdebarros,
elnyry-sam-k and
vijayg10
as code owners
tw-sithumyo
force-pushed
the
feat/add-merchant-registry-helms
branch
from
34ece5f to
ff7b9f6
Compare
|
Thanks @oderayi and @tw-sithumyo .. Please hold off on the merge while iterating on these changes; And until all the image versions used are greater than v1.0.0 indicating that they're release / production quality |
|
hello @oderayi , thanks for thorough review, I made changes according to your suggestions. |
tw-sithumyo
force-pushed
the
feat/add-merchant-registry-helms
branch
from
a8d077a to
ac3e6d0
Compare
|
version has been bumped to 1.0.x. |
tw-sithumyo
force-pushed
the
feat/add-merchant-registry-helms
branch
from
9a6f7ed to
809edd3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thanks @tw-sithumyo; Two items left from the sonar check, please review. |
|
|
Hello @elnyry-sam-k , the storaged limit related 2 issues has been resolved. |
|
Once this is ready, we'll have to change the "base" branch to "v16.0.0-rc-1" so that it can be tested with the v16 RC codebase and then shipped after passing the release criteria. |
|
@oderayi can you please take another look at this, as you've requested changes earlier. thank you! |
|
@tw-sithumyo , can you please do a quick check on this PR and address conflicts here? We're now looking at a v17 release candidate so if everything's good here, we can merge to main and go ahead with testing |
|
@elnyry-sam-k fixed the conflicts. |
|
|
approved @tw-sithumyo , can you please also review the testing tookit test cases PR: mojaloop/testing-toolkit-test-cases#142 so that it can be merged as well.. also, if possible can you deploy this version and check for deployment and also the merchant setup, test collections? we'll move forward with the v17 release shortly |
elnyry-sam-k
dismissed
oderayi’s stale review
All comments addressed; @oderayi, feel free to re-review. thanks
No description provided.