Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Modules to see isues that have been resolved or reopened as last action. #149

Merged
merged 7 commits into from
Apr 23, 2020

Conversation

NeunEinser
Copy link
Member

@NeunEinser NeunEinser commented Apr 22, 2020

Purpose

Resolves #144

Approach

This mostly just removes the filter from ModuleExecutor.
Most modules have not been changed. Here is a list of all modules and my thoughts:

  • Attachment: Should always see all issues and remove malicious attachments everywhere.
  • Crash: I don't see a problem here. If an issue is reopened from AR, it should obviously be checked here. I don't really see this module mistriggering, and if it does, an issue should be opened.
  • Empty: Empty has been changed to only resolve issues that were created after the last run.
  • FutureVersion: Don't see it being relevant here.
  • HideImpostors: Should always trigger on issues were impostors post.
  • KeepPrivate: Should always trigger on all issues that are to be kept private.
  • Language: LanguageModule has been changed to only resolve issues that were created after the last run.
  • Piracy: If there is a misstrigger, I guess that could become an issue, maybe a check that the latest change was not a reopen should be included?
  • RemoveNonStaffMeqs: Should always see all issues and remove comments from regular users trying to add MEQS tags.
  • RemoveTriagedMeqs: In case the issue is opened after the triage, for example because it had a REVIEW tag, the module should see this issue.
  • ReopenAwaiting: Now requires the last comment to be after the latest AR resolve.
  • ResolveTrash: Don't see it being relevant here, only sees Unreaolved tickets anyways.
  • RevokeConfirmation: Don't see it being relevant here.
  • UpdateLinked: Don't see it being relevant here.

Besides that the architecture was slightly adjusted to support passing the lastRun time can to modules.

Checklist

  • Included tests
  • Tested in MCTEST-xxx

@NeunEinser NeunEinser added the enhancement New feature or request label Apr 22, 2020
@NeunEinser NeunEinser changed the title Feature/144 Allow Modules to see isues that have been resolved or reopened as last action. Apr 22, 2020
Copy link
Member

@urielsalis urielsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as soon as the conflict is resolved

# Conflicts:
#	src/main/kotlin/io/github/mojira/arisa/ModuleRegistry.kt
#	src/main/kotlin/io/github/mojira/arisa/modules/ReopenAwaitingModule.kt
#	src/test/kotlin/io/github/mojira/arisa/modules/ReopenAwaitingModuleTest.kt
@NeunEinser NeunEinser merged commit e71bdfd into master Apr 23, 2020
@NeunEinser NeunEinser deleted the feature/144 branch April 23, 2020 10:40
urielsalis pushed a commit that referenced this pull request Oct 1, 2020
…t action. (#149)

* Modules can see all issues now

* There is always gonna be a ktlint commit

* Adjust awaiting response

* Add possibility to register module without lastRun

* cleanup after merge

* fix build after merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Arisa to work on issues that just have been resolved
2 participants