Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation of previous repair, but without significant performance hit #130

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Reimplementation of previous repair, but without significant performance hit #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/Minion/Backend/Pg.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,14 @@ sub repair {
my $minion = $self->minion;
$db->query("DELETE FROM minion_workers WHERE notified < NOW() - INTERVAL '1 second' * ?", $minion->missing_after);

# Old jobs
$db->query("DELETE FROM minion_jobs WHERE state = 'finished' AND finished <= NOW() - INTERVAL '1 second' * ?",
$minion->remove_after);
# Old jobs with no unresolved dependencies
$db->query(
"DELETE FROM minion_jobs
WHERE id IN (
SELECT id FROM minion_jobs WHERE state = 'finished' AND finished <= NOW() - INTERVAL '1 second' * ?
EXCEPT SELECT unnest(parents) AS id FROM minion_jobs WHERE state != 'finished'
)", $minion->remove_after
);

# Expired jobs
$db->query("DELETE FROM minion_jobs WHERE state = 'inactive' AND expires <= NOW()");
Expand Down
4 changes: 2 additions & 2 deletions t/pg.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,9 +1116,9 @@ subtest 'Job dependencies' => sub {
is_deeply $job->info->{children}, [], 'right children';
is_deeply $job->info->{parents}, [$id, $id2], 'right parents';
is $minion->stats->{finished_jobs}, 2, 'two finished jobs';
is $minion->repair->stats->{finished_jobs}, 0, 'no finished jobs';
is $minion->repair->stats->{finished_jobs}, 2, 'still two finished jobs';
ok $job->finish, 'job finished';
is $minion->stats->{finished_jobs}, 1, 'one finished job';
is $minion->stats->{finished_jobs}, 3, 'three finished job';
is $minion->repair->remove_after(172800)->stats->{finished_jobs}, 0, 'no finished jobs';
$id = $minion->enqueue(test => [] => {parents => [-1]});
ok $job = $worker->dequeue(0), 'job dequeued';
Expand Down
Loading