Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass commands a list to subprocess. Only use shell=True if required. #262

Open
NMNS93 opened this issue Jan 15, 2020 · 2 comments
Open

Pass commands a list to subprocess. Only use shell=True if required. #262

NMNS93 opened this issue Jan 15, 2020 · 2 comments

Comments

@NMNS93
Copy link

NMNS93 commented Jan 15, 2020

No description provided.

@NMNS93 NMNS93 changed the title Pass commands as lists to subprocess. Only use shell=True if required. Pass commands a list to subprocess. Only use shell=True if required. Jan 15, 2020
@aledj2
Copy link

aledj2 commented Oct 21, 2020

this can fail if a list of strings are provided

@RachelDuffin
Copy link
Contributor

Setting the shell parameter to true or another truthy value when invoking a subprocess can introduce security vulnerabilities, as it allows shell metacharacters and whitespace to be passed to child processes, potentially leading to shell injection attacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants