Await graphql handler to avoid unhandled promise rejections #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where the
graphqlHandler
function can reject. Notably, I have seen this when supplying an improperly formatted multipart request (e.g. invalid json). However, because the call to the graphql handler is not awaited, thecatch
which handles the error will not be invoked. Instead, this error will bubble out tomoleculer-web
which does not properly handle the rejected promise. This leads to an unhandled promise rejection in Node and, depending on node version, a hard failure of the NodeJS process.The solution is to simply await the execution of the graphql handler. In this case, if the handler rejects, then the
catch
will be properly invoked and there will not be an unhandled promise rejection.