Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/create mixin #61

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

devalexandre
Copy link
Contributor

Create a mixin , using js template and typescript template

@icebob
Copy link
Member

icebob commented Apr 6, 2022

Thanks the PR, but my problem is that, you created a well-known DB mixin as a default mixin. If I'm a developer and exec moleculer create mixin I expect, it will be a common skeleton mixin instead of full logic. By the way, most of developers uses project-template which contains this DB mixin, by default.

@devalexandre
Copy link
Contributor Author

Thanks the PR, but my problem is that, you created a well-known DB mixin as a default mixin. If I'm a developer and exec moleculer create mixin I expect, it will be a common skeleton mixin instead of full logic. By the way, most of developers uses project-template which contains this DB mixin, by default.

I understand, the idea would be not to use the Db Mixin, but to create your own mixin.
I will make the necessary changes.

@devalexandre
Copy link
Contributor Author

@icebob , I used mongoose to assemble the example, if you have any improvement just leave a comment :)

@devalexandre
Copy link
Contributor Author

@icebob any comments?

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the mixin name is regular, but the implementation is not regular and is very specific.

@devalexandre
Copy link
Contributor Author

The problem is that the mixin name is regular, but the implementation is not regular and is very specific.

I really didn't understand what you mean

@devalexandre
Copy link
Contributor Author

this PR don't is interesting ? @icebob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants