Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moleculer crash if file size is too large #313

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: moleculer crash if file size is too large #313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbfa0a3
fix: moleculer crash if file size is too large
0x0a0d Jul 27, 2022
8292275
add example
icebob Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/alias.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,11 @@ class Alias {
if (_.isFunction(busboyOptions.onFileSizeLimit)) {
busboyOptions.onFileSizeLimit.call(this.service, file, busboy);
}
file.destroy(new PayloadTooLarge({ fieldname, filename, encoding, mimetype }));
file.destroy();
busboy.emit("error", new PayloadTooLarge({ fieldname, filename, encoding, mimetype }));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this pull, below example will crash application
https://stackblitz.com/edit/node-3az7uh?file=index.js

});
file.on("error", err => {
busboy.emit("error", err);
});
numOfFiles++;
promises.push(ctx.call(this.action, file, _.defaultsDeep({}, this.route.opts.callOptions, { meta: {
Expand Down Expand Up @@ -209,7 +213,7 @@ class Alias {
});

/* istanbul ignore next */
busboy.on("error", err => {
busboy.once("error", err => {
req.unpipe(req.busboy);
req.resume();
this.service.sendError(req, res, err);
Expand Down