fix: updated closing dangling streams at src/transit.js #1307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added clean and close this.pendingResStreams when node disconnected
📝 Description
Fixed memory leak when another microservice started stream with broker.call and then switched off (with reboot for example)
Create 3 services, api-gw, test-1, test-2
api-gw handle request -> test-1
test-1 make stream and send it to test-2
test-2 send answer stream to test-1
test-1 send stream to api-gw
terminate test-2 process
If microservice test-2 was terminated (in active stream process) in api-gw service src/transit.js this.pendingResStreams and this.pendingRequests was not released/deleted
💎 Type of change
🏁 Checklist:
It is for close issue
#1296
Repo for reproduce this bug
https://github.com/JS-AK/moleculer-pr-1307-example