fix(changelog): should exclude file contents, search indexes and mg_ fields to keep storage use down #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswertz
changed the title
mswertz
changed the title
connoratrug
reviewed
Oct 3, 2024
backend/molgenis-emx2-sql/src/main/java/org/molgenis/emx2/sql/ChangeLogUtils.java
Show resolved
Hide resolved
…hange_log_skip_file_contents
connoratrug
reviewed
Oct 16, 2024
backend/molgenis-emx2-sql/src/main/java/org/molgenis/emx2/sql/ChangeLogUtils.java
Outdated
Show resolved
Hide resolved
connoratrug
reviewed
Oct 16, 2024
| } | ||
|
|
||
| public static String buildAuditTrigger(String schemaName, String tableName) { | ||
| return """ | ||
| CREATE TRIGGER %3$s_audit | ||
| CREATE OR REPLACE TRIGGER %3$s_audit |
There was a problem hiding this comment.
these should not be a trigger when the trigger is add , should fail fast
There was a problem hiding this comment.
the code assumes there is no trigger with this name , if there is a trigger with this name, something has gone (very) wrong and we should know , not suppress the error
connoratrug
reviewed
Oct 16, 2024
| @@ -220,7 +236,7 @@ static void executeMigrationFile(Database db, String sqlFile, String message) { | |||
| jooq.settings().setQueryTimeout(THREE_MINUTES); | |||
| String sql = new String(Migrations.class.getResourceAsStream(sqlFile).readAllBytes()); | |||
| jooq.execute(sql); | |||
| logger.debug(message + "(file = " + sqlFile); | |||
| logger.info(message + "(file = " + sqlFile); | |||
There was a problem hiding this comment.
currently we cannot see that migrations are executed. I think this is important enough to be 'info'
connoratrug
reviewed
Oct 16, 2024
backend/molgenis-emx2-sql/src/main/java/org/molgenis/emx2/sql/SqlTableMetadata.java
Outdated
Show resolved
Hide resolved
connoratrug
reviewed
Oct 16, 2024
I think we do. File contents are disturbing the changelog viewing and take much space. If we would want to log those it should be elsewhere. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
how to test:
notes: