Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (tailwind): add checkbox group component #4317

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Oct 4, 2024

What are the main changes you did:

  • Added checkbox group component
  • Added "icon" component for displaying checked and indeterminate status
  • Added e2e tests
  • Added story

how to test:

@davidruvolo51 davidruvolo51 self-assigned this Oct 4, 2024
@davidruvolo51 davidruvolo51 marked this pull request as ready for review October 8, 2024 10:54
@connoratrug
Copy link
Contributor

Can you merge this checkbox input with the Tree input , else we have duplicate checkbox code/styling

@connoratrug
Copy link
Contributor

still some small differences when compared to the prod version ( for usage in the ontology filter)

Screenshot 2024-10-16 at 09 40 04 Screenshot 2024-10-16 at 09 49 10

Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix the padding issue for use in ontology filter

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants