Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add demo style page to tailwind playground app #4329

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Oct 9, 2024

https://preview-emx2-pr-4329.dev.molgenis.org/apps/tailwind-components/#/Styles.other

What are the main changes you did:
it shows 'all' the styles that can be changed for a theme and the names of the classes

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

connoratrug and others added 2 commits October 9, 2024 16:48
it show 'all' the styles that can be changed for a theme and the names of the classes
Copy link
Contributor

@davidruvolo51 davidruvolo51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great to have in the component showcase. I have are a few comments, but the main suggestion is the shadow that occurs behind the text in the ColorTile component. I think it is caused by the tooltip element.

apps/tailwind-components/components/ColorTile.vue Outdated Show resolved Hide resolved
apps/tailwind-components/components/ColorTile.vue Outdated Show resolved Hide resolved
apps/tailwind-components/pages/Styles.other.vue Outdated Show resolved Hide resolved
@connoratrug
Copy link
Contributor Author

I updated the classes and added aumc to the theme select

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link
Contributor

@davidruvolo51 davidruvolo51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@connoratrug connoratrug merged commit 30277ca into master Oct 10, 2024
5 of 6 checks passed
@connoratrug connoratrug deleted the feat/tailwind-theme-style-page branch October 10, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants