feat(catalogue): model update to 5.1 #4345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add the changes to the pr description , its hard to make out from the long csv strings in the change |
I was not done yet with this PR, it is a draft. |
mswertz
changed the title
|
mswertz
approved these changes
Oct 14, 2024
|
waiting to merge until we can also migrate the data on acc to 5.1. (migrations are written, but need time to run them) |
connoratrug
reviewed
Oct 16, 2024
There was a problem hiding this comment.
nice, this is so much nicer then viewing the csv file
connoratrug
reviewed
Oct 16, 2024
| @@ -8,5 +8,6 @@ dependencies { | |||
| task generateTypes(type: JavaExec) { | |||
| group = 'application' | |||
| classpath = sourceSets.main.runtimeClasspath | |||
| workingDir = rootProject.projectDir | |||
There was a problem hiding this comment.
what does this do ? , why is it part of this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
how to test:
todo: