Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalogue): resource logo was not shown #4346

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did:

  • fix props for sidemenu logo
  • fix query for networks card logo

how to test:

  • note due to preview file/image issue, it can not be tested on the preview
  • locally ( proxy to prod or similar backend) or on server, run the pr branch and check logo's ( detail page sidemenu and networks card ) against prod.
    for example check 'EUChildNetwork/cohorts/ABCD' it has both a sidemenu log and networks logo's
    todo:
  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

- fix props for sidemenu logo
- fix query for networks card logo
Copy link

sonarcloud bot commented Oct 11, 2024

@mswertz mswertz changed the title fix: fix show resource logo fix(catalogue): resource logo was not shown Oct 13, 2024
@connoratrug connoratrug merged commit 810c8e9 into master Oct 14, 2024
6 checks passed
@connoratrug connoratrug deleted the fix/show-resource-logo branch October 14, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants