feat(tailwind-components): update header for design #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new data-explorer design has left aligned header - update breadcrumbs and pageheader with ts types and fix issues - add option to left align header - update breadcrumbs for ui app the match design ( [schema, table]) - add playground story for breadcrumbs
mswertz
changed the title
mswertz
approved these changes
Oct 14, 2024
| @@ -46,14 +46,9 @@ const ontologies = computed( | |||
| </script> | |||
| <template> | |||
| <Container> | |||
| <PageHeader :title="`Tables in ${data?.data._schema.label}`"> | |||
| <PageHeader :title="`Tables in ${data?.data._schema.label}`" align="left"> | |||
There was a problem hiding this comment.
I don't think I like the left align. Is that a design we agreed upon?
There was a problem hiding this comment.
There was a problem hiding this comment.
i makes sense as the whole page is left aligned and fullscreen ( yet to be implemented for the rest of the page) , its a different design then the catalogue list page
| tables: `/${schema}`, | ||
| }" | ||
| /> | ||
| <BreadCrumbs align="left" :current="data?.data._schema.label" /> |
yes the design has some more padding in the header ( see left edge header en filter ) , i'll add it |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
how to test:
todo: