Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emx2): changed the mimetype logic #4358

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix(emx2): changed the mimetype logic #4358

merged 4 commits into from
Oct 16, 2024
+3 −2

Conversation

harmbrugge
Copy link
Member

@harmbrugge harmbrugge commented Oct 15, 2024 •
edited
Loading

What are the main changes you did:

  • Change the mimetype logic so it works on java version <17.02

how to test:

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@harmbrugge harmbrugge self-assigned this Oct 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mswertz
mswertz reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I test this?

I noticed some concerns on stackoverflow this not working the same everywhere. I wanted to test if this works on our docker previews too?

@harmbrugge harmbrugge merged commit 4e63375 into master Oct 16, 2024
5 of 6 checks passed
@harmbrugge harmbrugge deleted the fix/mimetype-fix branch October 16, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

@MaxPostema MaxPostema Awaiting requested review from MaxPostema

@connoratrug connoratrug Awaiting requested review from connoratrug

Assignees

@harmbrugge harmbrugge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harmbrugge @mswertz