Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Arrays failed to validate using their validationRegexp #4359

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

svandenhoek
Copy link
Contributor

@svandenhoek svandenhoek commented Oct 15, 2024

What are the main changes you did:

  • Fixed the bug
  • Added test:
    • Pre-fix keySet: [STRING array, sTRINGArray]
    • Post-fix keySet: [sTRINGArray]

how to test:

  • Ensure all tests succeed

Sidenote: Weird camelCasing. Would expect stringArray instead. Perhaps worth fixing as well, though not sure if this would break things. Either way, out-of-scope for this PR.

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link

sonarcloud bot commented Oct 15, 2024

@svandenhoek svandenhoek marked this pull request as ready for review October 15, 2024 11:55
@svandenhoek svandenhoek merged commit 5df6df8 into master Oct 15, 2024
6 checks passed
@svandenhoek svandenhoek deleted the fix/email_array_identical_name_type branch October 15, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants