Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data (portal): data model changes #4593

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Jan 8, 2025

What are the main changes you did

Further changes to the portal data model

  • Fixed ontology file names so they load on schema load (NOTE this is a breaking change for existing models)
    • GenderAtBirth.csv => Gender at birth.csv
  • Data model fixes
    • Biosamples: changed column type for Collected by from ONTOLOGY_ARRAY to REF_ARRAY
    • Simplified Studies and Study table
    • AllowRecontacting table: added additional "not" categories for explicitly stating "No reporting..." rather than leaving values blank
    • Age groups at onset: added new ontology table for onset age groups; changed refTable in disease history

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be ';' as seperator right?

Copy link

sonarqubecloud bot commented Jan 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants