Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(central): default menu #4598

Merged
merged 8 commits into from
Jan 13, 2025
Merged

fix(central): default menu #4598

merged 8 commits into from
Jan 13, 2025

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Jan 10, 2025 •
edited
Loading

What are the main changes you did

  • do not assume order in the retuned list , but use the key to select the correct value from the key-value list

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug connoratrug changed the title fix: default menu fix(central): default menu Jan 10, 2025
@connoratrug connoratrug marked this pull request as ready for review January 10, 2025 13:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

dtroelofsprins
dtroelofsprins approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • OIDC login Apps/central
  • OIDC login on schema level
  • adjusted menu apps/central
  • Css apps/central
  • Landing_page OIDC login

@connoratrug connoratrug merged commit e5ea9e6 into master Jan 13, 2025
7 checks passed
@connoratrug connoratrug deleted the fix/custom-menu branch January 13, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtroelofsprins dtroelofsprins dtroelofsprins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @dtroelofsprins