Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add setup for visual e2e tests, and test themes used by catalogue #4603

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore: add setup for visual e2e tests, and test themes used by catalogue #4603

merged 3 commits into from
Jan 16, 2025

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

  • explain what you changed and essential considerations.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mswertz
mswertz approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volgens mij moeten we het proberen dus approve

@connoratrug connoratrug merged commit 9f53d75 into master Jan 16, 2025
7 checks passed
@connoratrug connoratrug deleted the chore/e2e-test-theme-render branch January 16, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

@davidruvolo51 davidruvolo51 Awaiting requested review from davidruvolo51

@YpeZ YpeZ Awaiting requested review from YpeZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @mswertz