-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tailwind-components): add form legend component #4616
Conversation
looks good, only links are breaking |
there are no links ( yet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code: Just some nitpicks, looks good.
Functional:
- error bubbles in the legend don't look right (firefox, chrome looks ok)
- in the form the error counts don't show (firefox/chrome)
- The current chapter is not being highlighted (firefox/chrome) initially, does after switching to the complex form.
apps/tailwind-components/tests/components/form/renderForm.spec.ts
Outdated
Show resolved
Hide resolved
fixed by switching to styled div instead of svg ( svg v-align has issue in firefox)
can not reproduce , can you add steps
can not reproduce , can you add steps ( note the 'simple' form does not start with a chapter ( not sure if this should be allows , or if we should use a 'default' chapter name if the field list does not start with a chpater) |
Ok while writing this I understand why it doesn't show. There is no heading for the unheaded first chapter. I think we should add something for this. Maybe a "Top of form" or something in case there the top field is not a header. I believe in the old forms we had something like this. yes, maybe but suggest not to put it in this pr, the final form has more options to show the error state , and i would like to discuss maken a chapter ( if any) madatory
yes , i would depend on things like the viewport size en size of the elements between 2 headers , imo the current setup is a good start, not this is not part of the components but the story , a final version may need to be tweaked depending its context ( modal , page ) i would like to do that once we have most form elements working. |
Quality Gate passedIssues Measures |
What are the main changes you did
How to test
Checklist