-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tailwind-components): Boolean field input #4630
Conversation
} | ||
|
||
const radioOptions = ref<RadioOptionsDataIF[]>([ | ||
{ value: true, label: "True" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that you want to use this internally make a lot of sense to me.
const radioOptions = ref<RadioOptionsDataIF[]>([ | ||
{ value: true, label: "True" }, | ||
{ value: false, label: "False" }, | ||
]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not required then a 'clear' is null is possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but got a few small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. My only comment is about the prop align
. Are there more alignment options other than vertical and horizontal. If not, maybe this could be a boolean prop. That would make it easier to use in other contexts.
:showClearButton="true" | ||
align="horizontal" | ||
@update:modelValue="onInput" | ||
@focus="$emit('focus')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is a fix for another PR)
When the radio group is focused, the inputs aren't visually focused. Focused styles for the input radio button is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what changes would you like to see ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like an issue, on the master branch related to the radio input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine now, however the when using the molgenis theme, the clear button is barely visible.
this is an effect of the demo page style , not element |
…boolean-field-input
|
feat: Boolean field input
What are the main changes you did
How to test
Checklist