Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add input hyperlink #4631

Merged
merged 13 commits into from
Jan 27, 2025
Merged

feat: add input hyperlink #4631

merged 13 commits into from
Jan 27, 2025

Conversation

chinook25
Copy link
Contributor

What are the main changes you did

  • Add tailwind form input for hyperlinks

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@chinook25 chinook25 self-assigned this Jan 23, 2025
@chinook25 chinook25 marked this pull request as ready for review January 27, 2025 09:23
@chinook25 chinook25 requested a review from connoratrug January 27, 2025 09:23
mswertz
mswertz approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Probably best if another programmer also checks.

connoratrug
connoratrug approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good , only the e2e test has an issue

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@connoratrug connoratrug merged commit d573f01 into master Jan 27, 2025
5 of 7 checks passed
@connoratrug connoratrug deleted the feat/input-hyperlink branch January 27, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

@connoratrug connoratrug connoratrug approved these changes

Assignees

@chinook25 chinook25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinook25 @mswertz @connoratrug